On Sun, Jun 29, 2014 at 10:33:56AM +0000, Florian Obser wrote: > So I noticed that check_bioctl wants to run as root (via sudo) to get > access to /dev/bio. This is unnecesarry, only bioctl(8) needs > privileges. > afresh1@ kindly rolled a new release and since maintainer email > bounces he agreed to take maintainer. > > Existing installs are not effected by this since root can call sudo > without password prompt. > > patch-check_bioctl is no longer needed since it's in the new release, too. > > OK?
OK by me. The only thing that is bugging me is just using sudo automatically. I wonder if it would be better to enable that with a flag, like `check_bioctl -S -d ami0` or something. Probably it's fine, but "feels weird". > diff --git Makefile Makefile > index b655708..774d121 100644 > --- Makefile > +++ Makefile > @@ -4,14 +4,13 @@ PKG_ARCH = * > > COMMENT = Nagios plugin to check RAID status with bioctl > > -DISTNAME = check_bioctl-1.16 > -REVISION = 0 > +DISTNAME = check_bioctl-1.20 > CATEGORIES = net > > -MAINTAINER = Michael Erdely <merd...@openbsd.org> > +MAINTAINER = Andrew Fresh <afre...@openbsd.org> > > HOMEPAGE = > https://www.monitoringexchange.org/inventory/Check-Plugins/Hardware/Devices/RAID-Controller/check_bioctl > -MASTER_SITES = > https://www.monitoringexchange.org/attachment/download/Check-Plugins/Hardware/Devices/RAID-Controller/check_bioctl/ > +MASTER_SITES = http://cvs.afresh1.com/nagios/ > > # BSD > PERMIT_PACKAGE_CDROM = Yes > diff --git distinfo distinfo > index be9ebfe..1010324 100644 > --- distinfo > +++ distinfo > @@ -1,5 +1,2 @@ > -MD5 (check_bioctl-1.16.tar.gz) = /fmeNhHOGY2DTbLizGJj+g== > -RMD160 (check_bioctl-1.16.tar.gz) = 8303+vneljRK39/5vALhtmizLes= > -SHA1 (check_bioctl-1.16.tar.gz) = CwWL3U9m4xUdPOJhU/3G/f6qyzY= > -SHA256 (check_bioctl-1.16.tar.gz) = > cRbq/Ioz3XyrqVauo491fu54oh3xuRjf91yEWr7690w= > -SIZE (check_bioctl-1.16.tar.gz) = 3037 > +SHA256 (check_bioctl-1.20.tar.gz) = > timzeip/4nqb4OUd2+zN21sv0G6EH20CwnWxfXtYiSI= > +SIZE (check_bioctl-1.20.tar.gz) = 2959 > diff --git patches/patch-check_bioctl patches/patch-check_bioctl > deleted file mode 100644 > index c642c53..0000000 > --- patches/patch-check_bioctl > +++ /dev/null > @@ -1,15 +0,0 @@ > -Account for changes in bioctl output from: > -http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/bioctl/bioctl.c.diff?r1=1.98;r2=1.99;f=h > - > -$OpenBSD: patch-check_bioctl,v 1.2 2012/04/04 21:49:44 merdely Exp $ > ---- check_bioctl.orig Sat Mar 31 13:32:08 2012 > -+++ check_bioctl Sat Mar 31 13:32:21 2012 > -@@ -158,7 +158,7 @@ sub read_bioctl { > - chomp $line; > - > - # Do these by columns cuZ that is the easiest for now > -- my @o = unpack( "A6 A1 A11 A15 A7 A9 A*", $line ); > -+ my @o = unpack( "A10 A1 A11 A15 A7 A9 A*", $line ); > - return if $o[0] eq 'Volume'; > - > - foreach (@o) { > > -- > I'm not entirely sure you are real. -- andrew - http://afresh1.com The 3 great virtues of a programmer: Laziness, Impatience, and Hubris. --Larry Wall
