On 22/06/14 7:48 AM, Jérémie Courrèges-Anglas wrote:
Hi,
Brad Smith <b...@comstyle.com> writes:
On Sun, Jun 22, 2014 at 05:01:38AM +0200, J??r??mie Courr??ges-Anglas wrote:
(Redirecting this to ports@)
Could you folks test this patch against dovecot from -stable? I only
did compile testing on -current. I don't know how the allocator(s)
handle failures nor how would i_realloc handle pwbuf_size ==
old_pwbuf_size, but this looks safe.
$OpenBSD$
Hack: we avoid the actual ERANGE error case by always providing a large
enough buffer.
I'd prefer to use the diff I had commited when this issue first came
up although back then local auth didn't work at all without the hack
that was added. I don't have a 5.5 system around at the moment so
please check this builds first and then test as appropriate.
FWIW this patch looks fine to me, but I still can't test it.
The comments about sysconf(_SC_GETGR_R_SIZE_MAX) look a bit scary, though...
That bit of code doesn't have any effect on modern OpenBSD. It is there
to workaround a bug with older OpenBSD releases..
CVSROOT: /cvs
Module name: src
Changes by: st...@cvs.openbsd.org 2011/04/25 14:10:10
Modified files:
include : grp.h
lib/libc/gen : getgrent.c sysconf.c
Log message:
Teach sysconf(_SC_GETGR_R_SIZE_MAX) the correct size of a buffer for the
reentrant getgrent functions (getgrgid_r, getgrnam_r).
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
