I haven't done much ports work, but from an Arduino perspective this is
correct so ok jj@ if that has any worth.
Den 19 jun 2014 21:56 skrev "Daniel Bolgheroni" <[email protected]>:
> On Thu, Jun 19, 2014 at 03:06:10PM +0100, Stuart Henderson wrote:
> >
> > Say the port is updated to 1.5.x, these -D lines will need to be
> > updated, right?
>
> Until now, we are fine using ARDUINO=100 even if we update to 1.5.x.
> This macro is being used, as of today, only to control the renaming
> scheme from WProgram.h to Arduino.h.
>
> I can't say what they will eventually do in the future. If they begin to
> use this variable to control every other renaming schemes or, worst,
> something else, we still need to set this to something >= 100 for 1.0.x.
>
> > What I am asking for is a comment, in the port Makefile,
> > not in a file hidden away in files/, reminding people to do that.
> > Does that make sense?
>
> Sure. OK?
>
> Thank you.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/arduino/Makefile,v
> retrieving revision 1.10
> diff -u -p -r1.10 Makefile
> --- Makefile 7 Aug 2013 21:31:29 -0000 1.10
> +++ Makefile 19 Jun 2014 19:53:24 -0000
> @@ -4,6 +4,9 @@ COMMENT= open-source electronics prototy
>
> V= 1.0.2
> PKGNAME= arduino-${V}
> +# Arduino uses the ARDUINO macro to control the renaming scheme they did
> +# on 1.0.x, from WProgram.h to Arduino.h. BSDmakefile, which defines
> +# it, may need to be updated accordingly.
> DISTNAME= arduino-${V}-src
> EPOCH= 0
> REVISION = 1
>
>
