On 2014/06/10 14:34, Anders Jensen-Waud wrote:
> Hi all, 
> 
> I have ported InspIRCd - a “lightweight modular” IRC server written in C++ to 
> OpenBSD. So far I have tested the port on amd64. Please see attached tarball.
> 
> (See http://www.inspircd.org/)
> 
> This requires a new user, inspircd, to be created. I have added it to the 
> file: /usr/ports/infrastructure/db/user.list
> 
> Anyone keen to help out with testing on i386 and other architectures? 
> 
> --
> Anders Jensen-Waud

Haven't tried building, but a few quick comments from reading:

relies on pluggable modules -> should be SHARED_ONLY, and merge
PFRAG.shared into PLIST in place of the %%shared%% tag

--uid=inspircd -> should have an underscore prefix (also check
that the port does actually build without the uid being present,
the user isn't created until pkg_add time)

needs @newuser in PLIST

CONFIGURE_STYLE=gnu -> incorrect, that is only for autoconf

patch-configure -> unneeded, set MAKE_FILE

bad DISTNAME, use DISTFILES to rename, see various other github ports

cleanup whitespace (space-tab on COMMENT/DISTNAME/CONFIGURE_ARGS)

license marker should be explicit that it's "GPLv2 only"

DESCR is a bit long, mentions features which are't in the package, and has
a spelling mistake


Reply via email to