On 2014/05/28 12:16, Jan Klemkow wrote:
> On Wed, May 28, 2014 at 09:38:09AM +0200, J??r??mie Courr??ges-Anglas wrote:
> > Matthew Dempsky <[email protected]> writes:
> > 
> > > On Tue, May 27, 2014 at 2:14 PM, J??r??mie Courr??ges-Anglas
> > > <[email protected]> wrote:
> > >> No proper license, approval required for patches and/or no
> > >> redistribution of binary packages, bla, bla.  I may not remember the
> > >> details well enough; like most people that were interested in
> > >> daemontools/qmail/djbdns/blah, but stopped using them long time ago.
> > >
> > > FWIW, most of DJB's code has been public domain for a while now:
> > > http://cr.yp.to/distributors.html
> > >
> > > In particular, ucspi-tcp has been public domain for 6+ years now.
> > 
> > Fair enough.  I guess that's enough to consider re-adding this package
> > to the tree, but I won't take that decision alone. :)
> 
> I added the licence (thank to Matthew for doing my homework :-) and
> apply the Path and Compiler nitpick from jca.
> 
> I hope, that this revision of this port is right and OK for everybody.
> 
> Thanks for you help,
> Jan

comments inline

| # $OpenBSD$
| 
| COMMENT=      tools for building tcp socket client/servers
| 
| DISTNAME=             ucspi-tcp-0.88
| REVISION=             0

(to confirm for anyone questioning this line, it *is* correct
as we previously had ucspi-tcp-0.88).

| CATEGORIES=           net

please fix <space><tab>

| 
| HOMEPAGE=             http://cr.yp.to/ucspi-tcp.html
| MAINTAINER=           Jan Klemkow <[email protected]>
| 
| PERMIT_PACKAGE_CDROM= Yes
| WANTLIB=              c

prefer a blank line before WANTLIB as done in Makefile.template and
most other ports.

| # Public domain

since it's not in the tarball, please add the URL to djb's announcement
about this.

| MASTER_SITES=         http://cr.yp.to/ucspi-tcp/
| MASTER_SITES+=                http://www.fefe.de/ucspi/
| PATCHFILES=           ucspi-tcp-0.88-ipv6.diff19.bz2

don't try and fetch the patch file from cr.yp.to; instead use
MASTER_SITES0 and add :0 to PATCHFILES. see mutt for an example.

| PATCH_DIST_STRIP=
| ALL_TARGET=
| 
| NO_TEST=              Yes
| 
| DOCFILES=             TODO README
| BINFILES=             tcpserver tcpclient tcprules tcprulescheck
| MANFILES=             tcpserver.1 tcpclient.1 tcprules.1 tcprulescheck.1
| 
| do-configure:
|       echo "${CC} ${CFLAGS}" > ${WRKSRC}/conf-cc
|       echo "${CC} ${LDFLAGS}" > ${WRKSRC}/conf-ld
|       echo "${TRUEPREFIX}" > ${WRKSRC}/conf-home
| 
| do-install:
|       ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/ucspi-tcp
| .for f in ${BINFILES}
|       ${INSTALL_PROGRAM} ${WRKSRC}/${f} ${PREFIX}/bin
| .endfor
| .for f in ${MANFILES}
|       ${INSTALL_MAN} ${WRKSRC}/${f} ${PREFIX}/man/man1
| .endfor
| .for f in ${DOCFILES}
|       ${INSTALL_DATA} ${WRKSRC}/${f} ${PREFIX}/share/doc/ucspi-tcp
| .endfor

the old port used upstream's install target, with this:

pre-install:
        @echo ${PREFIX} > ${WRKSRC}/conf-home

seems much neater than all the DOCFILES=blah BINFILES=bla MANFILES=...
and multiple lines in do-install.

the old port also had this...is this or something like it still needed?

# datasize limit in 'run' files is too low for ld.so
# to be able to pull in libc
LDFLAGS+=       -static

| .include <bsd.port.mk>

Reply via email to