On Wed, May 07, 2014 at 11:23:52PM +0100, Stuart Henderson wrote: > Some quick comments from a read-through of the files (but > not building/testing yet) :- > > opendnssec README: > - should follow style from ports/infrastructure/templates/README.template
I have updated the README to reflect README.template.
> - "vi /etc/softhsm.conf" should use ${SYSCONFDIR},
Nice catch, this has been fixed in this version.
> and I think the directory
> structure and ownership should be setup with @samples rather than
> telling people what to type.
The reason i made those steps manual is because i was not sure how much
of a relationship I should enforce between the opendnssec and softhsm
packages. I do agree that solving it via PLIST is cleaner given that
having an empty softhsm/ directory is acceptable if not being used.
I have added the directory to PLIST and updated the README accordingly.
The file owner still needs to be set manually though, maby this can be
accomplished in a better way?
>
> opendnssec PLIST:
> - no point @sample'ing /var/run/opendnssec/, you need to create it in the
> rc_pre in the rc script anyway because /var/run is cleared at boot.
> example in smokeping.
The only reason I have added the @sample is because I wanted to make
'make update-plist' happy. Without the @sample i get a "Bogus element
outside of every prefix" warning.
Given that this is fine then OpenDNSSEC actually creates that directory
itself when started, so a rc_pre is not needed.
> - @owner/@group need updating
I'm not sure what you mean by this, what am I missing? :)
> - you're using /var/opendnssec/ in this file but ${LOCALSTATEDIR} in README
>
> softhsm PLIST:
> - /var / ${LOCALSTATEDIR}
>
Using ${LOCALSTATEDIR} in the PLISTs also cause "Bogus element outside
of every prefix" warnings, maby this is OK?
I have updated the PLISTs for now.
Thanks a lot for taking a look!
Regards,
Patrik Lundin
softhsm.tgz
Description: application/tar-gz
opendnssec.tgz
Description: application/tar-gz
