Hi, Jérémie Courrèges-Anglas wrote on Thu, Jan 02, 2014 at 12:42:51AM +0100: > Rafael Sadowski <raf...@sizeofvoid.org> writes:
>> "Drop USE_GROFF since groff and mandoc produce identical output." > I don't think this is a good idea. + 1 > Lots of ports still need USE_GROFF, and having this in the template > reminds people to look at the groff and mandoc produced output. Exactly. Deciding whether a port must USE_GROFF may have become easier over time, mostly because many porters have collected experience, but it is still a non-trivial task that cannot even be fully automated, see http://www.openbsd.org/faq/ports/specialtopics.html#Mandoc for details. > shannon ~$ sqlite3 /usr/local/share/sqlports > SQLite version 3.8.0.2 OpenBSD > Enter ".help" for instructions > Enter SQL statements terminated with a ";" > sqlite> select count (1) from ports where USE_GROFF = 1; > 1744 There are probably some in there that don't strictly require USE_GROFF, but there are definitely still lots that do. What naddy@ has been doing lately is the harvesting of low-hanging fruit, removing USE_GROFF in cases where it's most definitly useless, with a strong bias of leaning towards the safe side, avoiding to touch anything by multiport commits that isn't 100% clean and safe. Yours, Ingo >> Index: Makefile.template >> =================================================================== >> RCS file: /cvs/ports/infrastructure/templates/Makefile.template,v >> retrieving revision 1.68 >> diff -u -p -r1.68 Makefile.template >> --- Makefile.template 2 Oct 2013 07:34:45 -0000 1.68 >> +++ Makefile.template 1 Jan 2014 23:17:42 -0000 >> @@ -102,7 +102,6 @@ MASTER_SITES = ??? >> #SEPARATE_BUILD = Yes (build in a directory other than WRKSRC) >> #SEPARATE_BUILD = flavored (distinct flavors may share a common WRKSRC) >> #USE_GMAKE = Yes >> -#USE_GROFF = Yes >> # Programs that require GNU libtool to build instead of the OpenBSD one >> # should use this option. >> #USE_LIBTOOL= gnu
