On cs, dec 19, 2013 at 14:14:40 +0100, Jérémie Courrèges-Anglas wrote: > LEVAI Daniel <l...@ecentrum.hu> writes: [...] > but you can keep the upstream version in the comment. [...]
This was fixed in the last tarball.
> >> | @bin lib/libscrypt.so.0
> >> | lib/libscrypt.so
> >>
> >> Library generation is wrong, there should be
> >> libscrypt.so.<version_from_shared_libs_line> and also either a
> >> static library, or make the port SHARED_ONLY.. I haven't built but
> >> I guess one of these files is a symlink and one is an incorrectly
> >> built library.
> >
> > Okay, I tried to do a better job this time. The source builds a
> > libscrypt.so.0 file, and I couldn't get pkg_create(1) to recognize the
> > lib mentioned in SHARED_LIBS, so I had to mv libscrypt.so.0 ->
> > libscrypt.so.0.0
> > I've also @comment-ed the symlink to ...so.0 in PLIST. Now the library
> > is correctly prefixed with @lib in the PLIST.
>
> Just patch the Makefile. We don't use -soname. What I'd do is ''-o
> libscrypt.so.${LIBscrypt_VERSION}'', you can pass the version in
> MAKE_FLAGS. The symlinks can be patched away while here.
Okay, thanks! I've attached a new archive that includes these changes.
> This still needs SHARED_ONLY, the .a isn't installed and building it
> should not involve -fPIC.
>
> PFRAG.shared can be merged in PLIST.
These were also fixed in the last tarball.
Daniel
--
LÉVAI Dániel
PGP key ID = 0x83B63A8F
Key fingerprint = DBEC C66B A47A DFA2 792D 650C C69B BE4C 83B6 3A8F
libscrypt.tar.gz
Description: application/tar-gz
