On 2013/12/11 14:08, Vadim Zhukov wrote:
> > kirby@ reminded that portimport(1) was not updated after portcheck(1)
> > import. Among other things, it allows to run portimport from custom
> > directory, which was requested by kirby@ in the first place.
> >
> > Any comments/okays on the following patch then?
>
> Improved version, after some input from sthen@. Also includes manual
> page update. okay?
>
> --
> zhuk@
> usage() {
> - echo "usage: $(basename $0) [-u username]" >&2
> + echo "usage: ${0##*/} [-U] [-p portsdir] [-u username]" >&2
> exit 1
> }
I'm still dubious about this one, the argument about special characters
seems bogus (we haven't had any problems with rc.subr which uses basename
and definitely has weirder filenames to deal with than "portimport") ..
I don't buy "de facto standard", basename is very common. I suppose it's
clear from the context what it's meant to do, but I don't see it commonly
used in scripts and if it was used outside of a usage() block it would
certainly have many readers wondering what it is..
