On 2013/11/08 20:07, Brian Callahan wrote: > On 11/7/2013 10:53 PM, Kent R. Spillner wrote: > >>License is GPLv2+ > >> > >>You can eliminate the a lot of patch-Makefile with a well-crafted > >>MAKE_FLAGS line in the port Makefile. You definitely don't need to > >>change INSTALL or PREFIX (you're using your own do-install routine > >>anyway). CC, FLAGS, INCLUDES, and LIB_DIRS could (read: should) all be > >>put under MAKE_FLAGS in the port Makefile (and therefore not be touched > >>in patch-Makefile). > >> > >>WRKBUILD->WRKSRC in the first line of the do-install routine. > > > >Attached is an updated version. Thanks again for your feedback! > > > > Two small tweaks, neither of which I think require you to resubmit this. > WANTLIB is missing c and you don't need LIBS in MAKE_FLAGS. > > This tests good for me on loongson and macppc. Can I get an OK to import, > with the two small tweaks noted above? > > ~Brian >
Please add a blank line after WANTLIB, and a bit of text to DESCR mentioning that by default you should press ctrl+alt+y to activate or hide it (because it doesn't do anything visible when you run it), then it's ok with me.
