On Tue, Sep 24, 2013 at 5:39 PM, Stuart Henderson <st...@openbsd.org> wrote:
> - "@owner root" / "@group wheel" don't belong in plist for this
That was my bad, I told him to add that as 'make package' complained
with out it.
>
> - check the linker command line;
>
> cc -s -o optipng optipng.o optim.o cbitset.o osys.o wildargs.o
> ../opngreduc/libopngreduc.a ../pngxtern/libpngxtern.a ../libpng/libpng.a
> ../zlib/libz.a ../gifread/libgifread.a ../pnmio/libpnmio.a
> ../minitiff/libminitiff.a -lm
>
> "-s" strips the installed binary; for ports, this can be done for a
> normal build but shouldn't be done if it's a debug build (e.g.
> make DEBUG="-g")
>
> to fix these two above, I would write a custom do-install target using
> ${INSTALL_PROGRAM} for the binary and ${INSTALL_DATA} for the manpage
> which uses correct permissions, ownership, and automatically uses -s
> unless it's a DEBUG build.
>
> - it should use the system libpng rather than a bundled copy; as well
> as the configure flag, you'll need
>
> CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE}/include" \
> LDFLAGS="-L${LOCALBASE}/lib"
>
> - stray space at end of COMMENT
>
>
>
>
