On Sep 18, 2013 4:25 PM, "Stuart Henderson" <st...@openbsd.org> wrote:
>
> It would be a bit more standard with the changes from the diff below.

Thanks!

> I don't like the "do-build" much though, this *is* running normal
> autoconf scripts internally so it would really be better to find
> a way to use CONFIGURE_STYLE=gnu which passes in the normal
> flags/variables and, importantly, copies in correct versions of
> config.status/config.guess/config.cache...

Sure, but the actual package has three separate configure-build sequences,
and they appear to be broken enough to build them separately. That said,
the port could be split in three (libzen, libmediainfo and mediainfo),
though the libraries don't appear to be used elsewhere.

> Other things, doesn't honour CFLAGS/CXXFLAGS, CC/CXX,

It honours CFLAGS, and making it honour the others seems trivial.

> it looks like it may pick up textproc/tinyxml if installed at build time.

It uses tinyxml2, which is not tinyxml 2.6.2 we have in ports. See
http://www.grinninglizard.com/tinyxml2docs/index.html for details.

> MIME attachments are preferred.

Sure, I just have no MIME-aware mail client ATM.

----
Dmitrij D. Czarkoff

Reply via email to