This diff is wrong, build will fail. I don't really see a problem with this filename anyway though, it's not like the github-standard "v1.0.1.zip" etc, it does contain "equinox-themes" in the name so it isn't going to conflict with other ports and is fairly obvious what it's for.
On 2013/08/21 01:56, Vadim Zhukov wrote: > Hello all. > > As requested by ajacoutot@, sending a separate mail to review this > patch. > > As you can see, the x11/gtk2-equinox-engine downloads badly named > distfile directly in ${DISTDIR}. I just added a DIST_SUBDIR here. > No bump needed. > > Found with portcheck. > > -- > WBR, > Vadim Zhukov > > > Index: x11/gtk2-equinox-engine/Makefile > =================================================================== > RCS file: /cvs/ports/x11/gtk2-equinox-engine/Makefile,v > retrieving revision 1.12 > diff -u -p -r1.12 Makefile > --- x11/gtk2-equinox-engine/Makefile 21 Mar 2013 08:48:56 -0000 1.12 > +++ x11/gtk2-equinox-engine/Makefile 19 Aug 2013 11:13:33 -0000 > @@ -11,6 +11,7 @@ REVISION= 1 > > DISTFILES= ${DISTNAME}${EXTRACT_SUFX} \ > 140449-equinox-themes-${V}${EXTRACT_SUFX} > +DIST_SUBDIR= equinox > > CATEGORIES= x11 > >