On 5/27/2013 2:41 PM, David Coppa wrote:
On Mon, 27 May 2013, Brian Callahan wrote:
Hi ports --
Here's a patch for audio/musique. It ensures that MP3 and FLAC files
can be played, and displays icons outside a Desktop Environment.
MP3 dependency catch by dmitry.sensei(@gmail.com). FLAC dependency
and missing icons found by me; fix for the missing icons taken from
www/minitube.
Works for me on amd64.
OK?
Why is plugins-ugly needed?
MP3 support.
minitube only has plugins-good...
And minitube doesn't play mp3s, it watches YouTube videos. I took your
minitube patch for the icon support only. Sorry if that was unclear.
To recap:
plugins-good: FLAC support
plugins-ugle: MP3 support
minitube patch: make sure icons always display
~Brian
Ciao,
David
Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/musique/Makefile,v
retrieving revision 1.2
diff -u -p -u -p -r1.2 Makefile
--- Makefile 2 Apr 2013 16:16:47 -0000 1.2
+++ Makefile 27 May 2013 16:09:35 -0000
@@ -3,7 +3,7 @@
COMMENT = graphical music player focused on a clean ui
DISTNAME = musique-1.2.1
CATEGORIES = audio
-REVISION = 0
+REVISION = 1
HOMEPAGE = http://flavio.tordini.org/musique/
@@ -23,6 +23,8 @@ MODULES = x11/qt4
LIB_DEPENDS = audio/taglib
RUN_DEPENDS = devel/desktop-file-utils \
+ multimedia/gstreamer-0.10/plugins-good \
+ multimedia/gstreamer-0.10/plugins-ugly \
x11/gtk+2,-guic
WRKDIST = ${WRKDIR}/musique
Index: patches/patch-src_utils_cpp
===================================================================
RCS file: patches/patch-src_utils_cpp
diff -N patches/patch-src_utils_cpp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_utils_cpp 27 May 2013 16:09:35 -0000
@@ -0,0 +1,19 @@
+$OpenBSD$
+
+Use the gnome icon theme unconditionally: fixes a problem with
+musique GUI not having icons when executed outside of a Desktop
+Environment.
+
+This fix is identical to the one in www/minitube, which is by
+the same author.
+
+--- src/utils.cpp.orig Sun May 26 12:21:35 2013
++++ src/utils.cpp Sun May 26 12:22:32 2013
+@@ -5,6 +5,7 @@
+
+ QIcon getIcon(const QString &name) {
+ #ifdef Q_WS_X11
++ QIcon::setThemeName("gnome");
+ return QIcon::fromTheme(name);
+ #else
+ return Extra::getIcon(name);
