After applying the diff and a recompile the import in python works fine. I
have tested it with a small project of mine and it generates images from
PDF there. Looks good to me.
I do not use pdfshuffler, but I will have a look at it tomorrow.
Thank you!
natano
On Fri, Apr 26, 2013 at 11:01:32PM +0200, Matthias Kilian wrote:
> On Fri, Apr 26, 2013 at 09:16:01PM +0200, Martin Natano wrote:
> > py-poppler complains about undefined symbols when importing. The
> > functions referenced by this symbols have been removed in poppler 0.18.
> > There is a bug report from 2011 upstream, but py-poppler didn't have a
> > new release since September 2009.
>
> Which means that it is broken in our tree since july, 2012. So is
> pdfshuffler, which depends on it. Looks like only few people (you?)
> are using it ;-)
>
> > natano
> > P.S.: I have contacted $MAINTAINER, but he is "just a user who once
> > submitted an update" and recommended to report the issue here.
>
> He submitted then *new* ports py-poppler and pdfshuffler.
>
> Anyway, here's a merge of the launchpad diff you mentioned (and a
> removal of MAINTAINER); please give it a try (and if you're using
> pdfshuffler, give it a try, too).
>
> Ciao,
> Kili
>
>
> Unbreak for poppler >= 0.18 (noticed by Martin Natano).
>
> Remove (inactive?) MAINTAINER.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/print/py-poppler/Makefile,v
> retrieving revision 1.8
> diff -u -p -r1.8 Makefile
> --- Makefile 21 Mar 2013 08:46:35 -0000 1.8
> +++ Makefile 26 Apr 2013 20:54:22 -0000
> @@ -6,9 +6,7 @@ DISTNAME= pypoppler-0.12.1
> PKGNAME= ${DISTNAME:S/^py/py-/}
> CATEGORIES= print
>
> -REVISION= 4
> -
> -MAINTAINER= Ido Admon <ido...@gmail.com>
> +REVISION= 5
>
> MASTER_SITES= ${HOMEPAGE}/trunk/development/+download/
> HOMEPAGE= http://launchpad.net/poppler-python/
> Index: patches/patch-poppler_defs
> ===================================================================
> RCS file: /cvs/ports/print/py-poppler/patches/patch-poppler_defs,v
> retrieving revision 1.1
> diff -u -p -r1.1 patch-poppler_defs
> --- patches/patch-poppler_defs 4 Jun 2011 19:07:59 -0000 1.1
> +++ patches/patch-poppler_defs 26 Apr 2013 20:54:22 -0000
> @@ -1,16 +1,83 @@
> $OpenBSD: patch-poppler_defs,v 1.1 2011/06/04 19:07:59 kili Exp $
> +
> +Let this work with poppler >= 0.18.
> +
> +https://bugs.launchpad.net/poppler-python/+bug/776234
> +
> +And follow API changes from poppler-0.16.
> +
> +
> --- poppler.defs.orig Sun Sep 27 11:07:59 2009
> -+++ poppler.defs Mon May 23 21:42:00 2011
> -@@ -1796,6 +1796,12 @@
> ++++ poppler.defs Fri Apr 26 22:49:32 2013
> +@@ -1646,58 +1646,6 @@
> + (return-type "GType")
> + )
> +
> +-(define-method render_to_pixbuf
> +- (of-object "PopplerPage")
> +- (c-name "poppler_page_render_to_pixbuf")
> +- (return-type "none")
> +- (parameters
> +- '("int" "src_x")
> +- '("int" "src_y")
> +- '("int" "src_width")
> +- '("int" "src_height")
> +- '("double" "scale")
> +- '("int" "rotation")
> +- '("GdkPixbuf*" "pixbuf")
> +- )
> +-)
> +-
> +-(define-method render_to_pixbuf_for_printing
> +- (of-object "PopplerPage")
> +- (c-name "poppler_page_render_to_pixbuf_for_printing")
> +- (return-type "none")
> +- (parameters
> +- '("int" "src_x")
> +- '("int" "src_y")
> +- '("int" "src_width")
> +- '("int" "src_height")
> +- '("double" "scale")
> +- '("int" "rotation")
> +- '("GdkPixbuf*" "pixbuf")
> +- )
> +-)
> +-
> +-(define-method get_thumbnail_pixbuf
> +- (of-object "PopplerPage")
> +- (c-name "poppler_page_get_thumbnail_pixbuf")
> +- (return-type "GdkPixbuf*")
> +-)
> +-
> +-(define-method render_selection_to_pixbuf
> +- (of-object "PopplerPage")
> +- (c-name "poppler_page_render_selection_to_pixbuf")
> +- (return-type "none")
> +- (parameters
> +- '("gdouble" "scale")
> +- '("int" "rotation")
> +- '("GdkPixbuf*" "pixbuf")
> +- '("PopplerRectangle*" "selection")
> +- '("PopplerRectangle*" "old_selection")
> +- '("PopplerSelectionStyle" "style")
> +- '("GdkColor*" "glyph_color")
> +- '("GdkColor*" "background_color")
> +- )
> +-)
> +-
> + (define-method render
> + (of-object "PopplerPage")
> + (c-name "poppler_page_render")
> +@@ -1795,6 +1743,12 @@
> + (define-method get_text
> (of-object "PopplerPage")
> (c-name "poppler_page_get_text")
> - (return-type "char*")
> ++ (return-type "char*")
> +)
> +
> +(define-method get_selected_text
> + (of-object "PopplerPage")
> + (c-name "poppler_page_get_selected_text")
> -+ (return-type "char*")
> + (return-type "char*")
> (parameters
> '("PopplerSelectionStyle" "style")
> - '("PopplerRectangle*" "rect")
