On 2013/04/11 14:57, Brad Smith wrote: > The following diff adds a dns64 FLAVOR to the Unbound port to integrate the > DNS64 support as provided by the Ecdysis project. > > Caveat.. do not run with the malloc flags J or U and thus also S. > This seems to expose bugs in the new code. > > Anyone who would be better at tracking down such bugs interested > in trying to find the root cause and fix them? > > I noticed a similar diff was posted back in 2011 for Unbound > 1.4.9 but it never actually went in.
It would be much better to get this upstream though - but there has been very little interest on unbound-users, I've asked people before to comment there so they can see that there is interest but nothing...upstream certainly aren't averse to it: http://marc.info/?l=unbound-users&m=130553190330861&w=2 "The patch is to be merged if good quality and useful for general audience. So I do not know. The source contrib directory in the tarball of unbound is useful for putting the patch meanwhile. ... [snip] ... I have simply not received patch(es) to put into the unbound contrib" but there are known problems, http://marc.info/?l=unbound-users&m=130530426030770&w=2 Mostly portability (which would be better if it was in-tree), but also some SERVFAIL situations. For example for IPv6 reverse lookups OUTSIDE of the NAT64 prefix (so for your native path). The code synthesizes PTRs for the NAT64 prefix, I guess it is broken at this point. I'm going to report that, but the slow release cycles of ecdysis makes it annoying." and sperreault's last post there mentioned that things needed re-checking. > OK? I guess having it in the port for now wouldn't hurt. But there are a couple of things we should do. Firstly make it clear in DESCR that it is experimental and that there are known problems. Secondly, the current patch is difficult to maintain if upstream make any changes to the config parser, I would rather remove the patches for the following files: configlexer.c configparser.c configparser.h and just rm them: post-extract: cd ${WRKSRC}/util && rm configlexer.c configparser.c configparser.h they will be regenerated automatically at build time (flex in base is OK for this; src/usr.sbin/unbound does the same). (TBH if anyone is spending time hacking on unbound, rather than fixing up this patchset, it would be more useful to work out how to rip out the port allocator and just use the OS port allocator instead, ideally in a way which is controlled by a build or config option so it can be fed back upstream, afaik that is the main obstacle to enabling unbound in base...)
