Stuart Henderson <s...@spacehopper.org> writes: [...]
> Normally I wouldn't even bother mentioning license in DESCR at all,
> but in this case, as it is AGPL which has requirements on the person
> *running* the software (and not just the person *distributing* the
> software) to make source code available, it's good to make sure the
> user is well aware of it.
That's my opinion too.
> A few other comments (I haven't tried building it though) :-
>
> - typo in DESCR: personnal/personal/
ack
> - discrepancy between license info in DESCR and in the comment
> in the Makefile?
The text in DESCR was from taken from the seeks website. I'll sync it
from the Makefile.
> - autoconf/automake are used but not listed in build dep's
> (use MODGNU_AUTOMAKE_DEPENDS / MODGNU_AUTOCONF_DEPENDS)
Oops.
> - just use docbook2man and have it rebuild the manpage; patching
> for this is just going to lead to maintenance problems.
> (pkglocate says docbook2man is in textproc/docbook2x).
Well, I'll just follow your advice, but I promise next release won't
ship with an out-of-date manpage!
> - hardcoded /etc should be ${SYSCONFDIR}
Sorry, I hope it's OK now (did the same for LOCALSTATEDIR).
> - the plugins shouldn't have version information / static libraries
> i.e. you have
>
> lib/seeks/plugins/httpserv/libseekshttpservplugin.a
> lib/seeks/plugins/httpserv/libseekshttpservplugin.la
> @lib
> lib/seeks/plugins/httpserv/libseekshttpservplugin.so.${LIBseekshttpservplugin_VERSION}
> (etc)
>
> should probably just be something like this,
>
> lib/seeks/plugins/httpserv/libseekshttpservplugin.so
About static libs, I overlooked SHARED_ONLY semantics.
Fixed with --disable-static and LIBTOOL_FLAGS.
About dlopened modules, well, this is a known problem that I try to fix
upstream. 0.4.1 was shipped with specific code for OpenBSD, to look for
plugins whose name ends in ".so*" instead of just ".so"...
Using -avoid-version now would need a bigger rework. For example tests
are linked directly to those modules (as if they were shared libs).
It would make it harder for me to post updates to enable regress tests
for this release (well, I think so. Perhaps is there an easy way I fail
to see).
Is that really a problem if this seeks version ships with versioned
plugins?
Thanks a lot to Stefan and you for your very useful feedback. I hope
the updated attached port will do.
--
Jérémie Courrèges-Anglas
GPG Key fingerprint: 61DB D9A0 00A4 67CF 2A90 8961 6191 8FBF 06A1 1494
seeks.tgz
Description: Binary data
