On 2012/12/22 12:48, MERIGHI Marcus wrote:
> update to fhem-5.3
>
> [email protected] (MERIGHI Marcus), 2011.06.22 (Wed) 22:07 (CEST):
> > COMMENT
> > house automation server written in perl
> >
> > HOMEPAGE
> > http://fhem.de/
> >
> > pkg/DESCR
> > Server for house automation written in perl. Supports ELV FS20,
> > ELV FHZ 1000 *, ELV EM 10x0-*, some Allnet devices, and, via busware.de
> > CUL and CUN devices, a lot more. Some weather sensors are supported as
> > well. It reads sensors and sends commands to actors and can be
> > configured to run automated tasks on events. Can be controlled via cli
> > (netcat/telnet, fhem.pl) and web interfaces (which are not included).
> >
> > looking forward to comments on my first port!
- use ${SYSCONFDIR} rather than hardcoded /etc and ${TRUEPREFIX}
rather than /usr/local
- rather than patching away the entire install target in upstream's
Makefile it would probably make more sense to use do-install in the
port Makefile
- why rename the config file from fhem.cfg to fhem.conf?
- rc_pre is OK for things in /var/run which are cleared at boot
anyway (though normally use install rather than touch + chown + chmod),
but logs etc should be handled in the package. it probably
makes more sense to just install a blank log directory owned by
the correct userid (with an @extraunexec rm -rf /var/log/fhem/*
before the @sample so that pkg_delete -c works), and then use
a subdirectory of /var/run i.e. just install a directory and
let fhem create the files itself).
- "/var/run/fhem.save contains state information if the
distributed config file is used. will be saved before shutdown"
-> looks like this should be kept between boots, so /var/run is
the wrong place to store it as it's cleared at boot and from
/etc/daily. probably something in /var/db instead? as above
create the directory via @sample in the PLIST.
- the new user must be created in PLIST (@newuser)
- the README should follow the formatting of
/usr/ports/infrastructure/templates/README.template
