On Thu, Dec 20, 2012 at 10:49:40PM +0100, Stefan Sperling wrote: > On Thu, Dec 20, 2012 at 03:08:45PM -0600, joshua stein wrote: > > If the specific exceptions only come after people like Edd are > > actually using the software and finding that it is much more usable > > with the optimization bump, what's the harm? > > Yes, I agree. Especially WRT games/emulators. If bugs in compilers are > uncovered because of this, all the better. If we don't turn it on blindly > for stuff that hasn't been tested I don't see a problem.
Well, Espie has made it pretty clear that he will not allow -O3. If you want better performance from emulators etc, then you will have to do a custom package setting CFLAGS and CXXFLAGS. Don't forget to rebuild and reinstall after every pkg_add -u. The following diff atleast makes fs-uae listen to CFLAGS and CXXFLAGS. ok? Index: Makefile =================================================================== RCS file: /cvs/ports/emulators/fs-uae/Makefile,v retrieving revision 1.5 diff -u -p -u -r1.5 Makefile --- Makefile 7 Dec 2012 08:43:06 -0000 1.5 +++ Makefile 20 Dec 2012 22:00:48 -0000 @@ -6,7 +6,7 @@ COMMENT = modern Amiga emulator V = 2.0.1 DISTNAME = fs-uae-$V CATEGORIES = emulators -REVISION = 1 +REVISION = 2 HOMEPAGE = http://fengestad.no/fs-uae/ MAINTAINER = Edd Barrett <e...@openbsd.org> @@ -34,7 +34,8 @@ RUN_DEPENDS = devel/desktop-file-utils x11/py-wxPython USE_GMAKE = Yes -MAKE_FLAGS += prefix=${PREFIX} + +MAKE_FLAGS += prefix=${PREFIX} CXXFLAGS="${CXXFLAGS}" CFLAGS="${CFLAGS}" NO_REGRESS = Yes Index: patches/patch-libfsemu_Makefile =================================================================== RCS file: /cvs/ports/emulators/fs-uae/patches/patch-libfsemu_Makefile,v retrieving revision 1.1.1.1 diff -u -p -u -r1.1.1.1 patch-libfsemu_Makefile --- patches/patch-libfsemu_Makefile 22 Nov 2012 23:45:20 -0000 1.1.1.1 +++ patches/patch-libfsemu_Makefile 20 Dec 2012 22:00:48 -0000 @@ -1,9 +1,9 @@ $OpenBSD: patch-libfsemu_Makefile,v 1.1.1.1 2012/11/22 23:45:20 edd Exp $ -Missing libpng flags +Missing libpng flags. Strip hardcoded CFLAGS ---- libfsemu/Makefile.orig Tue Nov 20 00:28:32 2012 -+++ libfsemu/Makefile Tue Nov 20 00:28:44 2012 +--- libfsemu/Makefile.orig Fri Oct 26 17:28:39 2012 ++++ libfsemu/Makefile Tue Dec 18 21:28:36 2012 @@ -36,7 +36,7 @@ warnings = -Wall errors = -Werror=implicit-function-declaration cppflags = $(CXXFLAGS) @@ -13,3 +13,16 @@ Missing libpng flags $(CFLAGS) -D_FILE_OFFSET_BITS=64 objects = obj/emu_emu.o obj/emu_video.o obj/emu_audio.o obj/emu_input.o \ obj/emu_menu.o obj/emu_texture.o obj/emu_font.o \ +@@ -53,12 +53,6 @@ objects = obj/emu_emu.o obj/emu_video.o obj/emu_audio. + + ldflags = $(LDFLAGS) + libs = +- +-ifeq ($(debug), 1) +- cflags += -g -O0 -fno-inline +-else ifneq ($(noflags), 1) +- cflags += -g -O2 +-endif + + ifeq ($(os), windows) + -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
