On Wed, Nov 28, 2012 at 09:24:18PM +0100, Landry Breuil wrote:
> On Wed, Nov 21, 2012 at 10:57:22PM +0100, Dmitrij D. Czarkoff wrote:
> > Hello!
> >
> > I've made a port for Uzbl web browser (see attachment). The port comes in
> > two
> > flavors:
> >
> > * default (using webkit-gtk3)
> > * "gtk2" (using webkit)
> >
> > Works for me, but input is welcome. I believe this browser to be worth
> > inclusion in ports.
>
> Comments portswise :
>
> - this is not the way we fix the shebang for python scripts. see
> python module and MODPY_ADJ_FILES.
> - no need to RUN_DEPENDS on www/webkit, since you already LIB_DEPENDS on
> it. and for gtk2, no need to use 'www/webkit,' the extra comma is
> useless.
and added to that, share/uzbl/{docs,examples} is usually not the way we
do things, rather share/{doc,examples}/uzbl.
Landry
