> Here is a diff that has actually been really tested - i'm pretty sure
> you didnt even run it, nor tried to run the regress tests. Making a port
> build is one thing, checking that it does what it's supposed to is another.

Yes, I didn't run it yet. I was planning to do it shortly.

>> +BUILD_DEPENDS=       textproc/libxslt
>
> Missing build depends on docbook-xsl and ImageMagick
>
>> +LIB_DEPENDS= databases/postgresql \
>> +             devel/json-c \
>> +             devel/proj \
>> +             geo/gdal \
>> +             geo/geos \
>> +             graphics/jasper
>
> What's the point of all those when json-c and gdal are enough ?

gdal is pulling in geos, so its cool.

> And it's also quite nice to have the html doc generated; and the
> manpages installed. Added a README explaining how to LD_PRELOAD
> libpthread.so since it's required by postgis, and also provide a working
> do-regress target that doesnt need manual intervention by the user.
>
> Taking maintainership from eric@ since he doesn't use it anymore.

cool. i wouldn't have figured out the LD_PRELOAD thing anyway at this
stage. thanks a lot for fixing the port!

Reply via email to