On Sat, Oct 20, 2012 at 09:41:45PM +0100, Stuart Henderson wrote:
> On 2012/10/20 14:26, Aaron Bieber wrote:
> > > - this should be renamed or symlinked to a filename which doesn't
> > > change for every port update; since this is based on lua 5.1 I have
> > > taken the approach of the main lua port and named it luajit51.
> >
> > Added the below to PLIST to reflect this change:
> >
> > @bin bin/luajit${MODLUA_DEP_VERSION}
>
> ah yes, late change in my diff, forgot to sync it - though I'm
> still not 100% sure whether this makes sense and would welcome others'
> opinions on this.
>
> I'm OK with committing this but I think I'd be equally happy with
> installing the binary as just luajit.
>
> > > . looking at patches, rather than patching wrksrc/Makefile to set
> > > variables and then SUBST_CMD them, you can just override them via
> > > MAKE_FLAGS. (MAKE_ENV gets overridden by variables set in a
> > > Makefile whereas MAKE_FLAGS overrides vars in a Makefile).
> >
> > This is the second time this has been pointed this out to me :P. I will
> > be more mind full of it.
>
> this confused me for ages when I started porting things (and I was a
> bit unsure if it would work here due to the secondary invocation of
> make, but thought I'd give it a go anyway and it worked out ;)
>
> > I also removed the blurb about "symlink for luajit" from the Makefile's
> > install: section because it was confusing.
>
> fine with me.
> This version has a few fixes that landry@ suggested: - remove i386/amd64 constraint - remove symlinks from makefile to prevent extra files showing up in PLIST I have an OK from sthen@ - looking for one more.
luajit.tgz
Description: application/tar-gz
