On 2012-09-25 at 23:04:52 -0400, Lawrence Teo wrote:
> On Mon, Sep 24, 2012 at 12:42:19PM -0400, Adam Jeanguenat wrote:
> > I've also given this some testing on -current i386 and have no issues
> > to report. Great work.
> >
> > Looking at http://lteo.net/stuff/snort-2.9.3.1.diff2, I noticed the
> > use of the auto-generated download IDs as the MASTER_SITES for daq and
> > snort. I've run into problems before when committing those IDs to
> > documentation, as I've seen them change within the same snort/daq
> > release.
> >
> > To make life easier, Sourcefire provides a URL that works without
> > respect to the automatically-incremented ID number for every file upload
> > to snort.org:
> >
> > http://www.snort.org/snort-downloads/cli
> >
> > Attached is a patch for net/snort/Makefile, (to be applied after
> > snort-2.9.3.1.diff2), and a corresponding patch for net/daq/Makefile.
> > These should make future maintenance a bit easier.
> >
> > I tested them both by starting fresh and following the instructions
> > here in the above URL, then applied both of the patches after
> > snort-2.9.3.1.diff2, then did a `make` in net/snort. With lteo's patch
> > daq is built automatically via WANTLIB, so it's not necessary to build
> > it separately first.
> >
> > Any thoughts?
>
> Hi Adam,
>
> Thank you for letting us know about the better download URL. For now, I
> have gone ahead and committed Markus's original diff to make it easier
> to discuss changes to the Snort port going forward.
>
> About your diff, it looks good, but introducing VERSION is generally
> only needed if DISTNAME and PKGNAME are different (for an example,
> please look at productivity/taskwarrior/Makefile).
>
Thanks; that was a definite oversight. I would agree it doesn't make
any sense to use VERSION here.
--avj
