sdl-config --cflags unconditionally sets _GNU_SOURCE,
as non posix glibc functions are often hidden under this
ifdef it tends to break code and I see no reason to define it.

This would ideally be tested in a bulk build though.

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/sdl/Makefile,v
retrieving revision 1.86
diff -u -p -r1.86 Makefile
--- Makefile    16 May 2012 14:01:19 -0000      1.86
+++ Makefile    23 Aug 2012 01:36:09 -0000
@@ -5,7 +5,7 @@ COMMENT=        cross-platform multimedia libra
 VERSION=       1.2.15
 DISTNAME=      SDL-${VERSION}
 PKGNAME=       ${DISTNAME:L}
-REVISION=      2
+REVISION=      3
 CATEGORIES=    devel
 MASTER_SITES=  ${HOMEPAGE}release/
 
Index: patches/patch-configure
===================================================================
RCS file: /cvs/ports/devel/sdl/patches/patch-configure,v
retrieving revision 1.24
diff -u -p -r1.24 patch-configure
--- patches/patch-configure     22 Mar 2012 13:00:42 -0000      1.24
+++ patches/patch-configure     23 Aug 2012 01:36:09 -0000
@@ -1,7 +1,18 @@
 $OpenBSD: patch-configure,v 1.24 2012/03/22 13:00:42 dcoppa Exp $
---- configure.orig     Thu Jan 19 07:30:12 2012
-+++ configure  Thu Mar 22 13:52:46 2012
-@@ -21000,6 +21000,20 @@ _ACEOF
+--- configure.orig     Thu Jan 19 17:30:12 2012
++++ configure  Thu Aug 23 11:25:36 2012
+@@ -15825,6 +15825,10 @@ case "$host" in
+         BASE_CFLAGS="-I/usr/include/mingw -mno-cygwin"
+         BASE_LDFLAGS="-mno-cygwin"
+         ;;
++    *-*-openbsd*)
++        BASE_CFLAGS=""
++        BASE_LDFLAGS=""
++        ;;
+     *)
+         BASE_CFLAGS="-D_GNU_SOURCE=1"
+         BASE_LDFLAGS=""
+@@ -21000,6 +21004,20 @@ _ACEOF
      fi
  }
  
@@ -22,7 +33,7 @@ $OpenBSD: patch-configure,v 1.24 2012/03
  CheckPulseAudio()
  {
      # Check whether --enable-pulseaudio was given.
-@@ -24073,6 +24087,12 @@ fi
+@@ -24073,6 +24091,12 @@ fi
                      x11_lib='libX11.so'
                      x11ext_lib='libXext.so'
                      ;;
@@ -35,7 +46,7 @@ $OpenBSD: patch-configure,v 1.24 2012/03
                  *)
                      x11_lib=`find_lib "libX11.so.*" "$X_LIBS 
-L/usr/X11/$base_libdir -L/usr/X11R6/$base_libdir" | sed 's/.*\/\(.*\)/\1/; q'`
                      x11ext_lib=`find_lib "libXext.so.*" "$X_LIBS 
-L/usr/X11/$base_libdir -L/usr/X11R6/$base_libdir" | sed 's/.*\/\(.*\)/\1/; q'`
-@@ -29551,6 +29571,7 @@ _ACEOF
+@@ -29551,6 +29575,7 @@ _ACEOF
          CheckALSA
          CheckARTSC
          CheckESD
@@ -43,7 +54,7 @@ $OpenBSD: patch-configure,v 1.24 2012/03
          CheckPulseAudio
          CheckNAS
          CheckX11
-@@ -29586,7 +29607,7 @@ _ACEOF
+@@ -29586,7 +29611,7 @@ _ACEOF
                  SOURCES="$SOURCES $srcdir/src/audio/sun/*.c"
                  have_audio=yes
              ;;

Reply via email to