On Fri, Jun 29, 2012 at 4:42 PM, Aaron Bieber <def...@gmail.com> wrote: > On Fri, Jun 29, 2012 at 02:18:18PM -0600, Aaron Bieber wrote: >> Hi, >> >> This patch updates node.js from 0.8.0 to 0.8.1 . I waited for a bit >> before submitting this one - so hopefully the checksums stay the same :P >> >> * V8: upgrade to v3.11.10.12 >> * npm: upgrade to v1.1.33 >> - Support for parallel use of the cache folder >> - Retry on registry timeouts or network failures (Trent Mick) >> - Reduce 'engines' failures to a warning >> - Use new zsh completion if aviailable (Jeremy Cantrell) >> * Fix #3577 Un-break require('sys') >> * util: speed up formatting of large arrays/objects (Ben Noordhuis) >> * windows: make fs.realpath(Sync) work with UNC paths (Bert Belder) >> * build: fix --shared-v8 option (Ben Noordhuis) >> * doc: `detached` is a boolean (Andreas Madsen) >> * build: use proper python interpreter (Ben Noordhuis) >> * build: expand ~ in `./configure --prefix=~/a/b/c` (Ben Noordhuis) >> * build: handle CC env var with spaces (Gabriel de Perthuis) >> * build: fix V8 build when compiling with gcc 4.5 (Ben Noordhuis) >> * build: fix --shared-v8 option (Ben Noordhuis) >> * windows msi: Fix icon issue which caused huge file size (Bert Belder) >> * unix: assume that dlopen() may clobber dlerror() (Ben Noordhuis) >> * sunos: fix memory corruption bugs (Ben Noordhuis) >> * windows: better (f)utimes and (f)stat (Bert Belder) > > Missed changes in the PLIST:
I think you need to update the Makefile to change the post-install hook to use npm/npm/node_modules instead of just npm/node_modules. That's the cause for most of the PLIST churn. With your current diff, all of npm's dependencies no longer show up as global node libraries. Also, I'm not sure I agree with the @extraunexec line (even though it's in the current port). We don't have something similar for other most programming languages (php, railo, and node are the only lang ports that use @extraunexec, and php and railo don't appear to go as far). If I install a node library manually with npm, and then do pkg_delete node pkg_add node I expect the library to be there after the pkg_add. AFAIK, one of the guiding principles of the OpenBSD package system is that it does not delete things it didn't create (espie@ can correct me if I'm wrong here). Jeremy