On 2012/04/10 13:37, Remi Locherer wrote: > Hi > > On Tue, Apr 10, 2012 at 11:43:36AM +0100, Stuart Henderson wrote: > > On 2012/04/07 08:14, Jim Razmus wrote: > > > Tested all three on i386 and amd64 -current. > > > > > > Note that p5-MojoX-Session will fail make regress due to the lack of POD > > > documentation in two of the modules. However, after removing TEST_POD, > > > the regress will complete without any other errors. > > > > > > feedback? ok to commit? > > > > I don't use any of this, but it reads OK, I think you could go ahead > > and commit it. > > > > I don't really understand why we enable TEST_POD anyway, isn't this > > more of an upstream-developer type of test? I'm all for removing it if > > it fails and stops other tests from running. > > > > Maybe you can add a dependency to p5-IO-Socket-SSL for www/p5-Mojoi/Makefile. > It's not strictly required but without that "mojo get https://some.url"; > does not work. > > RUN_DEPENDS = security/p5-IO-Socket-SSL>=1.37
Probably makes sense. > In www/p5-Mojo/pkg/DESCR Perl 5.8.7 is referenced as dependeny but with > new Mojo versions it's 5.10.1. Think I would just drop the version number here..
