On 2012/03/30 00:51, Mike Erdely wrote: > Attached is a port to check the general health of of an ESX/i server. > Tested on a Dell PE 840 running ESXi 5 with the py-wbem port submitted > by Mark Peoples. > > I've also attached the distfile as a tarball since the author releases > the script as an unversioned Python script on his website. I'm hoping > Stu (or someone) can host the distfile. > > check_esxi_hardware.tgz = port > check_esxi_hardware-20111003.tar.gz = distfile > > OK? > > -ME
"# Licence : GNU General Public Licence (GPL) http://www.gnu.org/"; arrh, another of these ... they need to read the "How to Apply These Terms to Your New Program" of the GPL, without explicitly including Copyright (c) <YYYY> <Name> lines this isn't a valid license grant. Can you talk to upstream and ask them to fix this (and maybe for versioned distfiles ;) in the meantime I think it wouldn't be a big problem to do as in the diff below as they clearly intend for it to be GPL, just didn't do it right (but I would like a second opinion :) Diff also uses python.port.mk support to patch the script (and replacement tgz attached). This works nicely for me. $ ./check_esxi_hardware --host=10.15.5.15 -U root -P file:$HOME/.vm-pw \ -i "Unspecified 0 CPU0 Dmn 0 Temp" OK - Server: HP ProLiant ML110 G5 s/n: CZ1827020Y System BIOS: O15 2008-04-03 diff --git Makefile Makefile index 1c84cad..d4904d3 100644 --- Makefile +++ Makefile @@ -12,10 +12,10 @@ MAINTAINER = Michael Erdely <merd...@openbsd.org> HOMEPAGE = http://www.claudiokuenzler.com/nagios-plugins/check_esxi_hardware.php MASTER_SITES = http://spacehopper.org/mirrors/ -# GPL -PERMIT_PACKAGE_CDROM = Yes +# "License: GPL" but no copyright assignment +PERMIT_PACKAGE_CDROM = botched GPL assignment PERMIT_PACKAGE_FTP = Yes -PERMIT_DISTFILES_CDROM =Yes +PERMIT_DISTFILES_CDROM =botched GPL assignment PERMIT_DISTFILES_FTP = Yes NO_BUILD = Yes @@ -26,9 +26,9 @@ RUN_DEPENDS = net/nagios/plugins,-main \ MODULES = lang/python -do-configure: - @perl -pi -e 's,/usr/bin/python,${MODPY_BIN},g' \ - ${WRKDIR}/check_esxi_hardware.py +WRKSRC = ${WRKDIR} + +MODPY_ADJ_FILES= check_esxi_hardware.py do-install: ${INSTALL_DATA_DIR} ${PREFIX}/libexec/nagios
check_esxi_hw.tgz
Description: application/tar-gz
