On Tue, Jan 24, 2012 at 10:05:54AM -0500, Brian Callahan wrote: > On 1/14/2012 9:39 PM, Brian Callahan wrote: > >Hi, > >Attached is a new port. > > > >pkg/DESCR: > >Beret is a 2D puzzle-platformer game about a scientist, astonishingly > >named Beret, who has gained telekinetic abilities through his research > >at the Evil Corporation. He decides that the Evil Corporation is a tad > >too evil for his liking, and begins his solitary quest to overthrow the > >corporation and punish the evil deeds of his employers. > > > >Tested and works on a variety of platforms, notably i386 and amd64. > >I am also volunteering to be the port maintainer. > > > >OK? > > > >Thanks. > > > >~Brian > Resubmit, with tweaks.
Looks good to me. As you are the developer, I'll share some comments (very minor issues mind): * Does not restore one of my monitor's resolutions properly upon exit. * Can I play in windowed mode? * I see you added -Wall, so you might be interested in: ===> Building for beret-1.2.1 clang -O2 -pipe -I/usr/local/include -I/usr/local/include/SDL -Wall -c game.c game.c:1619:41: warning: use of '%n' in format string discouraged (potentially insecure) [-Wformat-security] if (deflt > -1) sprintf(inputstr, "%d%n", deflt, &inputpos); Cheers -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
