On Sun, Jan 08, 2012 at 08:40:12PM +0100, Marc Espie wrote:
> Can you at least provide links to the executable with sensible names ?
> or heck, rename them and the corresponding manpage.
>
> Outside of Windows, it doesn't make any sense to have a .pl extension,
> the scripts should be called 'youtube-playlists' and 'youtube-download'.
Sure, I'll talk with author if he can drop .pl extensions. Also will
work with him to make Term::ANSIColor optional in further releases, but
for now is below inlined patch okay?
Changes from my previous (todays) patch:
- droped .pl extension from the scripts
- typo and style fix
- missing req in Makefile.PL
Index: Makefile
===================================================================
RCS file: /cvs/ports/www/p5-WWW-YouTube-Download/Makefile,v
retrieving revision 1.4
diff -u -r1.4 Makefile
--- Makefile 26 Aug 2011 09:03:13 -0000 1.4
+++ Makefile 8 Jan 2012 21:10:40 -0000
@@ -3,7 +3,7 @@
COMMENT = simple YouTube interface for downloading videos
MODULES = cpan
-DISTNAME = WWW-YouTube-Download-0.32
+DISTNAME = WWW-YouTube-Download-0.38
CATEGORIES = www
MAINTAINER = Mikolaj Kucharski <miko...@kucharski.name>
@@ -20,9 +20,18 @@
MODCPAN_EXAMPLES = Yes
MODCPAN_EXAMPLES_DIST = eg
-RUN_DEPENDS = www/p5-libwww \
- www/p5-URI \
+RUN_DEPENDS = devel/p5-Term-ANSIColor \
converters/p5-JSON \
- www/p5-HTML-Parser
+ textproc/p5-XML-TreePP \
+ www/p5-HTML-Parser \
+ www/p5-URI \
+ www/p5-libwww
+
+post-install:
+ ${MODCPAN_POST_INSTALL}
+ mv -f ${PREFIX}/bin/youtube-download{.pl,}
+ mv -f ${PREFIX}/bin/youtube-playlists{.pl,}
+ mv -f ${PREFIX}/man/man1/youtube-download{.pl,}.1
+ mv -f ${PREFIX}/man/man1/youtube-playlists{.pl,}.1
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/www/p5-WWW-YouTube-Download/distinfo,v
retrieving revision 1.4
diff -u -r1.4 distinfo
--- distinfo 26 Aug 2011 09:03:13 -0000 1.4
+++ distinfo 8 Jan 2012 21:10:40 -0000
@@ -1,5 +1,5 @@
-MD5 (WWW-YouTube-Download-0.32.tar.gz) = l3usE74P8TNq8kcWXJBEjw==
-RMD160 (WWW-YouTube-Download-0.32.tar.gz) = W8Xm5yO20hcElh6xa7toSUV12bI=
-SHA1 (WWW-YouTube-Download-0.32.tar.gz) = 8UG1kxu3RRJu9JHUaosXxbFod8Q=
-SHA256 (WWW-YouTube-Download-0.32.tar.gz) =
Adhf7sgwMcGTY/5PiOIahk611lKlen4LTrSXEIprxxU=
-SIZE (WWW-YouTube-Download-0.32.tar.gz) = 35796
+MD5 (WWW-YouTube-Download-0.38.tar.gz) = 1pk9bEwpc6zwQMrcyIfR3w==
+RMD160 (WWW-YouTube-Download-0.38.tar.gz) = skvDA0K/4EsHW2t0EQpbuG41IsU=
+SHA1 (WWW-YouTube-Download-0.38.tar.gz) = 9GE/kZ13ScuoIdCNIe38rK0CThE=
+SHA256 (WWW-YouTube-Download-0.38.tar.gz) =
MN0ZSYcgRXIxAMZW23ZM7AP8Axfi6kNebw/yKw1R7UY=
+SIZE (WWW-YouTube-Download-0.38.tar.gz) = 34185
Index: patches/patch-Makefile_PL
===================================================================
RCS file: /cvs/ports/www/p5-WWW-YouTube-Download/patches/patch-Makefile_PL,v
retrieving revision 1.2
diff -u -r1.2 patch-Makefile_PL
--- patches/patch-Makefile_PL 31 Jul 2011 18:09:57 -0000 1.2
+++ patches/patch-Makefile_PL 8 Jan 2012 21:10:40 -0000
@@ -3,13 +3,17 @@
Module::Install::AuthorTests is missing in ports tree,
but not really essential.
---- Makefile.PL.orig Tue Jan 4 15:17:14 2011
-+++ Makefile.PL Mon Jan 10 22:22:02 2011
-@@ -8,7 +8,6 @@ requires 'JSON';
+--- Makefile.PL.orig Thu Oct 6 21:40:56 2011
++++ Makefile.PL Sun Jan 8 19:58:58 2012
+@@ -7,10 +7,10 @@ requires 'URI::QueryParam';
+ requires 'LWP::UserAgent';
+ requires 'JSON';
requires 'HTML::Entities';
++requires 'Term::ANSIColor'; # for youtube-download and youtube-playlists
+ requires 'XML::TreePP'; # for youtube-playlists.pl
tests 't/*.t t/*/*.t';
-author_tests 'xt';
- test_requires 'Test::More', '0.96';
- auto_include;
+ install_script 'bin/youtube-download.pl', 'bin/youtube-playlists.pl';
+
Index: patches/patch-lib_WWW_YouTube_Download_pm
===================================================================
RCS file: patches/patch-lib_WWW_YouTube_Download_pm
diff -N patches/patch-lib_WWW_YouTube_Download_pm
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-lib_WWW_YouTube_Download_pm 8 Jan 2012 21:10:40 -0000
@@ -0,0 +1,15 @@
+$OpenBSD$
+
+- typo and remove period at the end of the line
+
+--- lib/WWW/YouTube/Download.pm.orig Wed Dec 7 15:44:45 2011
++++ lib/WWW/YouTube/Download.pm Sun Jan 8 20:03:59 2012
+@@ -268,7 +268,7 @@ __END__
+
+ =head1 NAME
+
+-WWW::YouTube::Download - Very simply YouTube video download interface.
++WWW::YouTube::Download - Very simple YouTube video download interface
+
+ =head1 SYNOPSIS
+
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/www/p5-WWW-YouTube-Download/pkg/PLIST,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 PLIST
--- pkg/PLIST 25 Apr 2011 13:04:17 -0000 1.1.1.1
+++ pkg/PLIST 8 Jan 2012 21:10:40 -0000
@@ -1,6 +1,10 @@
@comment $OpenBSD: PLIST,v 1.1.1.1 2011/04/25 13:04:17 todd Exp $
+bin/youtube-download
+bin/youtube-playlists
${P5SITE}/WWW/YouTube/
${P5SITE}/WWW/YouTube/Download.pm
+@man man/man1/youtube-download.1
+@man man/man1/youtube-playlists.1
@man man/man3p/WWW::YouTube::Download.3p
share/examples/p5-WWW-YouTube-Download/
share/examples/p5-WWW-YouTube-Download/cb.pl
--
best regards
q#
