On Fri, Sep 16, 2011 at 08:57:10AM +0200, Alexander Hall wrote:
> On 09/16/11 00:27, Mikolaj Kucharski wrote:
>
> > -@exec-update test -f ${MODAPACHE_FINAL} && cp -fp %D/%F ${MODAPACHE_FINAL}
> > +@exec-update if test -f ${MODAPACHE_FINAL}; then cp -fp %D/%F
> > ${MODAPACHE_FINAL}; fi
>
> Ports is not my thing, but sh scripting is. I'd suggest using
>
> -@exec-update test -f ${MODAPACHE_FINAL} && cp -fp %D/%F ${MODAPACHE_FINAL}
> +@exec-update test ! -f ${MODAPACHE_FINAL} || cp -fp %D/%F ${MODAPACHE_FINAL}
>
> instead, which apart from being smaller also has the benefit of
> failing if the cp(1) fails.
Cool, I'll prepare patch for that today or tomorrow then.
--
best regards
q#
