On 2011-07-09, Piotr Sikora <piotr.sik...@frickle.com> wrote:
> attached port of Google's compression library.

> SHARED_ONLY =           Yes
> USE_GMAKE =             Yes

these should be removed, there's a perfectly good static lib,
and it works fine with normal make.

> CATEGORIES =           devel

archivers is better as the main category, it can go in devel as
a secondary one.

> CONFIGURE_ARGS +=       ${CONFIGURE_SHARED} \
>                         --disable-gtest \

gtest should just be a standard BUILD_DEPENDS, it's only a single
package with no deps, and small enough, so there's no point in
REGRESS_FLAGS hacks and a patch which are only there to reduce the
build depends. I've left gflags disabled as it doesn't seem to
add much to the port/tests.

> @comment share/doc/snappy/COPYING

We do need a copy of the license ("Redistributions in binary form
must reproduce the above copyright notice, this list of conditions
and the following disclaimer") but that's ok in this case as
the license is included in the headers in the package.

> @comment share/doc/snappy/NEWS
> @comment share/doc/snappy/README

these have useful information, I've un-@comment'ed them.

DESCR is a bit long, I've reworded it slightly and added some
useful information (C++, optimized for LE LP64).

also corrected WANTLIB (doesn't use libc).

updated tgz attached. any OKs to import?

Attachment: snappy.tgz
Description: application/tar-gz

Reply via email to