On 2011-05-25, Jolan Luff <jo...@gormsby.com> wrote: > > --9jxsPFA5p3P2qPhR > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > This is a G.729a codec implementation for Asterisk. Lightly tested on > amd64. > > Comments? OKs?
please switch the PKGNAME to asterisk-g729-1.1beta2, pkg_add has special handling for version numbers with 'beta' in but not 'b' (see src/regress/usr.sbin/pkg_add/check-name). license-wise - missing license marker, and PERMIT_DISTFILES_FTP should be disabled too (the distfile contains code under Intel's IPP license without the proper license text - but as that code isn't built by the port, I think that PERMIT_PACKAGE_FTP is ok). I'd welcome another pair of eyes over this though.