On Thu, May 19, 2011 at 10:32:25AM +0000, Stuart Henderson wrote:
> any comments on this?

The gcc4 snippet makes sense to me, ok.

> On 2011-05-13, Stuart Henderson <s...@spacehopper.org> wrote:
> > On 2011-05-13, Landry Breuil <lan...@rhaalovely.net> wrote:
> >> On Fri, May 13, 2011 at 04:58:51PM +0000, Stuart Henderson wrote:
> >>> On 2011-05-13, Christopher Zimmermann <madro...@zakweb.de> wrote:
> >>> > So, heres the finished pdftk port.
> >>> >
> >>> > One last thing I'm uncertain about is whether to specify -O2 in 
> >>> > GCJFLAGS 
> >>> > or rather not do so. Compile time gets about factor 10x slower, but 
> >>> > binary size is reduced from ~8M to ~3.5M.
> >>> 
> >>> Here's a diff on top. I'm using the system definitions for some of
> >>> the variables and defaulting GCJFLAGS to CXXFLAGS and picking up opt
> >>> values that way. Also added WANTLIB.
> >>> 
> >>> Systrace problem doesn't affect the build and also affects classpath
> >>> so should probably be looked at in the gcc port and/or module sometime,
> >>> that's not a showstopper.
> >>> 
> >>> But we need a change to gcc4.port.mk so the LIB_DEPENDS for the gcj
> >>> lib can be added in the module rather than hardcoded in the ports using
> >>> it (I've done that temporarily here but it's wrong). So I'll send a
> >>> new tar.gz after I've looked at that.
> >>
> >> Fwiw id be very happy to have that in ports, so i'll ok it gladly :)
> >
> > This is what I'm thinking for gcc4.port.mk
> >
> > Index: gcc4.port.mk
> >===================================================================
> > RCS file: /cvs/ports/lang/gcc/4.2/gcc4.port.mk,v
> > retrieving revision 1.12
> > diff -u -p -r1.12 gcc4.port.mk
> > --- gcc4.port.mk    26 Mar 2011 19:13:28 -0000      1.12
> > +++ gcc4.port.mk    13 May 2011 19:40:56 -0000
> > @@ -59,6 +59,8 @@ _MODGCC4_LINKS += egfortran gfortran
> >  
> >  .  if ${MODGCC4_LANGS:L:Mjava}
> >  BUILD_DEPENDS += gcj->=4.2,<4.3|gcj->=4.2v0,<4.3v0:lang/gcc/4.2,-java,java
> > +MODGCC4_GCJWANTLIB = gcj
> > +MODGCC4_GCJLIBDEP = 
> > gcj->=4.2,<4.3|gcj->=4.2v0,<4.3v0:lang/gcc/4.2,-java,java
> >  _MODGCC4_LINKS += egcj gcj egcjh gcjh ejar gjar egij gij
> >  .  endif
> >  
> >
> >
> 

Reply via email to