On 2011-05-01, Ido Admon <ido...@gmail.com> wrote:
> 1. The desktop icons etc. that some people may want are installed in
> a separate makefile target, that must be called explicitly. There must
> be a more elegant way of doing that than the one I've found (patching
> the Makefile).
INSTALL_TARGET (the analogue for building is ALL_TARGET).
> 2. Two source files can't seem to find the poppler header that they're
> trying to #include (they have no trouble finding gtk etc.). Again, my
> crude solution of patching them must have a better alternative.
Try something like CONFIGURE_ARGS= CPPFLAGS=-I${LOCALBASE}/include
> 3. I put this under textproc - would x11 be a better fit?
Either is probably ok, x11 might be slightly better
Other notes
- DESCR should be wrapped, maybe trim things a bit - I'd go for
something like this:
Xournal is an application for notetaking, sketching and keeping a journal
using a stylus. It is similar to Microsoft Windows Journal or to other
alternatives such as Jarnal, Gournal, and NoteLab.
It can also be used to annotate PDF files (highlight, underline etc.),
and either save the annotations in a separate file, or export the
annotated document as a new PDF file.
- patches should be generated with "make update-patches" (though the
patches you have now are unnecessary)
- needs some @exec in the PLIST for icons and desktop files and
a run dependency on desktop-file-utils
- use CONFIGURE_STYLE=gnu, remove BUILD_DEPENDS and AUTOCONF_VERSION,
these are used when you have to regenerate the configure script whichs
you aren't doing
