Le dim 03/04/11 22:42, "Mikolaj Kucharski" miko...@kucharski.name a écrit: > I would need some assitance for style changes here.. > > http://marc.info/?l=openbsd-ports&m=130136674303767&w=2 > On Tue, Mar 29, 2011 at 02:44:18AM +0100, Mikolaj Kucharski wrote: > > Hi, > > > > Port needs some style changes. I've skipped python > part, I will look > into it at some stage, maybe during next port > upgrade. > > > Builds fine, regress passes. Didn't had a chance to > test it in my > environment yet, but my plan is to use pactester(1) > (part of pacparser) > for regressions at work. > > > > Also, I'm aware I could use more MAKE_FLAGS instead > of overriding build, > install and regress targets, but for now I would > like to keep the port that way.
Hello, Please use the Makefile included in tarball to build and install. Don't recreate do-build, do-install if there is a correct Makefile upstream (easier to maintain). I think you must "play" with WRKDIR infrastructure (http://www.openbsd.org/faq/ports/differences.html#wrkdir), like adding WRKSRC = ${WRKDIST}/src or something like that (not tested, but your "cd ${WRKDIST}/src" could be replaced). And, as you said, override variables in our Makefile is better, not in patching (easier to maintain). Cheers, Remi.
