Re: [NEW] mtkbabel for GPS devices based on MTK chipset

[Landry Breuil]

On Wed, Mar 30, 2011 at 04:50:02PM +0400, Sergey Bronnikov wrote:
> On 10:09 Wed 30 Mar , Landry Breuil wrote:
> > On Wed, Mar 30, 2011 at 11:55:40AM +0400, Sergey Bronnikov wrote:
> > > On 09:03 Wed 30 Mar , Landry Breuil wrote:
> > > > On Wed, Mar 30, 2011 at 09:53:00AM +0400, Sergey Bronnikov wrote:
> > > > > Hi!
> > > > > could you please review new port and commit it in source tree?
> > > > 
> > > > No $OpenBSD$ rcs ids, 
> > > added
> > > 
> > > > uses old-style depends with ::, 
> > > replaced by new-style depends with :
> > 
> > new-style depends dont need a : at all if you dont need to specify a
> > pkgspec
> removed :
> 
> > > > i think theres no
> > > > need for EXTRACT_SUFX,
> > > how to do same w/o EXTRACT_SUFX ?
> > 
> > EXTRACT_SUFX defaults to .tar.gz, unless the perl module changes it but
> > iirc that's not the case
> 
> hmm. Quote from bsd.port.mk(5):
> EXTRACT_SUFX  Used to set DISTFILES default value to
>                               ${DISTNAME}${EXTRACT_SUFX}.  Default value is 
> .tar.gz.
> You right, my fail.
> 
> > > > and MESSAGE should go away if the provided README
> > > yep! example described in README and in man page
> > > 
> > > > contains such example.
> > > > Upstream doesnt provide an install target ?
> > > don't understand question
> > 
> > i just find strange that you need to roll your own do-install target,
> > usually upstream makefile provides one.
> replaced to install target

no, that was correct to use do-install, i was only wondering if the
upstream provided one. Obviously not.

Here's a fixed version with PKG_ARCH = *, fixed licence marker (gplv2+),
fixed COMMENT, no need for PKGNAME (its not a perl module), reformatted
DESCR and use INSTALL_MAN/INSTALL_SCRIPT in do-install.
That should be ready for import.

Landry

mtkbabel.tgz
Description: application/tar-gz