Ingo Schwarze <schwa...@usta.de> wrote:

> Note that groff-1.20 still built with standard make,
> but groff-1.21 wants gmake, or the build silently fails
> to build libgnu.a, which causes the troff and grotty binaries
> to be missing in the end.

It has come to accidentally depend on MAKEOVERRIDES, a GNU make
extension that prevents the recursive passing of command line
assignments to sub-makes.  Specifically, we must not pass overrides
like top_srcdir=... to the sub-makes called in src/libs/gnulib where
those variables have different values created by the sub-configure
there.

It took me forever to figure that one out.


diff -uNr groff.orig/Makefile groff/Makefile
--- groff.orig/Makefile Mon Mar 14 01:50:29 2011
+++ groff/Makefile      Tue Mar 15 01:08:25 2011
@@ -17,7 +17,6 @@
 
 MASTER_SITES =         ${MASTER_SITE_GNU:=groff/}
 
-USE_GMAKE =            Yes
 MAKE_FLAGS +=          docdir=${PREFIX}/share/doc/groff \
                        exampledir=${PREFIX}/share/examples/groff
 
diff -uNr groff.orig/patches/patch-Makefile_in groff/patches/patch-Makefile_in
--- groff.orig/patches/patch-Makefile_in        Thu Jan  1 01:00:00 1970
+++ groff/patches/patch-Makefile_in     Tue Mar 15 01:21:14 2011
@@ -0,0 +1,12 @@
+$OpenBSD$
+--- Makefile.in.orig   Tue Mar 15 01:08:46 2011
++++ Makefile.in        Tue Mar 15 01:19:09 2011
+@@ -686,7 +686,7 @@ subdir=src/roff/troff
+ 
+ 
+ $(TARGETS):
+-      @$(ENVSETUP); $(MAKE) $(MAKE_K_FLAG) $(MDEFINES) do=$@ $(dodirs)
++      @$(ENVSETUP); $(MAKE) $(MAKE_K_FLAG) do=$@ $(dodirs)
+ 
+ dot: FORCE
+       @$(ENVSETUP); \
-- 
Christian "naddy" Weisgerber                          na...@mips.inka.de

Reply via email to