On Tue, Feb 15, 2011 at 3:32 PM, Ian Darwin <i...@darwinsys.com> wrote:
> As Edd Barrett points out, the xxxterm port is broken in that the
> desktop goo gets installed wrongly. This was put together by me &
> Laurent & Marco and somehow got committed with a mixture of commands:
>
> @${SUBST_CMD} -c ${WRKSRC}/xxxterm.desktop
> ${PREFIX}/share/applications/xxxterm.desktop
> ${INSTALL_DATA} ${WRKSRC}/xxxterm.desktop ${PREFIX}/share/applications/
>
> Obviously the second one overwrites the effects of the first.
>
> Should this go in as an unbreak now, or wait until after?
Even better, just use:
${SUBST_CMD} -o ${SHAREOWN} -g ${SHAREGRP} -c ${WRKSRC}/xxxterm.desktop \
${PREFIX}/share/applications/xxxterm.desktop
Instead of:
@${SUBST_CMD} -c ${WRKSRC}/xxxterm.desktop
${PREFIX}/share/applications/xxxterm.desktop
${CHOWN} ${SHAREOWN}:${SHAREGRP} $(PREFIX)/share/applications/xxxterm.desktop
Ciao,
David
