On Fri, Jan 07, 2011 at 02:45:36PM +0100, frantisek holop wrote: > hmm, on Fri, Jan 07, 2011 at 11:50:23AM +0000, Federico G. Schwindt said that > > On Fri, Jan 07, 2011 at 12:01:48PM +0100, frantisek holop wrote: > > > here it goes again, without whitespace change, > > > also cvs rm'ed the patchfile and here is 'cvs di -uNp' > > > as per Stuart's instructions (thanks): > > > > you can always do the whitespace change and send it with diff -w > > i prefer to deviate as little as possible from the repository. > it's not like i made up some rules in the template how the > whitespace should look like... i am just trying to follow them. > > i use the template for new ports, but it seems that > existing ports don't get whitespace fix commits..
they should, espie@ clearly stated that but i think you're mixing things up. when you need to review diffs it's easier if they don't have the whitespace (ymmv) so sending it with -w makes sense. for committing however the whitespaces should be added. if you have commit access it makes sense using -w so you the diff without spaces and when you get an OK you commit the real thing. f.-
