On Sat, Oct 2, 2010 at 11:49 PM, Landry Breuil <lan...@rhaalovely.net> wrote:
> On Sat, Oct 02, 2010 at 08:21:27PM -0700, Jeremy Evans wrote:
>> Fairly simple version update, lots of new features, see
>> http://www.scintilla.org/ScintillaHistory.html.
>>
>> -$OpenBSD: patch-src_KeyWords_cxx,v 1.3 2008/03/22 11:44:42 steven Exp $
>
> cvs log doesn't explain this patch... are you sure it can be safely
> removed ?
Yes. The original problem was the while loop would never finish. I
talked to the Scintilla developer years ago about it and it was
because we are using shared linking of the scintilla lexers, when only
static linking is supported, and it was caused by some difference
between the two. Without changing the while into a for with a defined
number of lexers, SciTE would hang on startup. I tested it without
the patch (which no longer applies because the source file has been
removed), and it doesn't hang, so I assume the problem has been
resolved upstream.
As to why we are using shared linking for scintilla and the lexers
when only static is supported upstream, that's how it was before I
took over maintenance.
>> Index: scite/patches/patch-src_Embedded_properties
>> - command.scite.help=netscape "file://$(SciteDefaultHome)/SciTEDoc.html"
>> -+ command.scite.help=firefox "file://__DOCDIR__/SciTEDoc.html"
>> ++ command.scite.help=firefox
>> "file:///usr/local/share/doc/scite/SciTEDoc.html"
>
> This should be patched to use ${LOCALBASE} + run ${SUBST_CMD} on it.. or
> __DOCDIR__ if it still exists or one of the Makefile variable available.
>
> ok otherwise.
OK, I'll make that change.
Jeremy
