On Mon, Aug 23, 2010 at 10:51:53PM +0200, Markus Bergkvist wrote:
>
> On 08/22/10 22:51, Federico G. Schwindt wrote:
> >On Sun, Aug 22, 2010 at 10:04:07PM +0200, Markus Bergkvist wrote:
> >>A work-in-progress port of mediatomb, I'm stuck and need some help:
> >>
> >>* the configure script picks up spidermonkey headers (jsapi.h) but
> >>the libjs/libsmjs link fails, shouldn't "checking for JS_NewObject
> >>in -ljs" work?
> >>
> >>* how do I get it to pick up ffmpeg support?
> >
> > I've had a port for this for some time (based on djm@ submission) but
> >never managed to mail it for one reason or another.
> > IIRC, I didn't have these issues so attached if you want to review it
> >or play with it. btw, at the time I tested it with ps3.
> >
> > f.-
> Thanks.
> The libs needed -pthread to be picked up by configure.
>
> I've been tweaking your port with
> * added --disable-inotify
> * added ffmpegthumbnailer
> * the first part of the ThreadPool.c patch seemed superflous so I
> removed it, correct me if I was wrong.
>
> Will play some more with it and my ps3 tomorrow.
Your patch for ThreadPool.c is wrong. You didn't remove OpenBSD from the
first ifdef. As for the first part of it, although my diff was wrong you
still want to return the min/max priorities, so it should be something
like this (not a real diff so you'll have to adapt it):
#if (defined(HAVE_SCHED_GET_PRIORITY_MIN) &&
defined(HAVE_SCHED_GET_PRIORITY_MAX)) || defined(__OpenBSD__)
..
+#if !defined(__OpenBSD__)
minPriority = sched_get_priority_min( currentPolicy );
maxPriority = sched_get_priority_max( currentPolicy );
+#else
+ minPriority = 0;
+ maxPriority = 31;
+#endif
..
OpenBSD does not have those functions but does have the priorities.
A few other comments:
- Look at the Makefile.template and try to follow it (spaces, order, etc)
- Switch to new dependency style (I've been hit with the cluestick so why
not pass this knowledge)
Other than that untested.
f.-
