On 08/17/10 01:48, Thomas de Grivel wrote:
On 08/15/10 02:47, Josh Elsasser wrote:
On Sat, Aug 14, 2010 at 11:50:44PM +0200, Thomas de Grivel wrote:
On 08/14/10 21:46, Josh Elsasser wrote:
On Sat, Aug 14, 2010 at 08:38:27PM +0200, Thomas de Grivel wrote:
On 07/31/10 19:14, Josh Elsasser wrote:
The included patch updates sbcl to 1.0.41, which eliminates a number
of patches and adds powerpc support. Note that this adds and removes
several files in pkg/ and patches/, so patch -E is your friend.

[snipped]




I'd love to test it.
Your patch almost applies to CVS head.


$ cd /usr/ports/lang/sbcl/&& make clean build
===> Cleaning for sbcl-1.0.41
===> sbcl-1.0.41 depends on: texlive_base-* - found
===> sbcl-1.0.41 depends on: clisp-* - found
===> sbcl-1.0.41 depends on: gmake-* - found
===> sbcl-1.0.41 depends on: bzip2-* - found
===> Verifying specs: c m util c m util
===> found c.56.0 m.5.2 util.11.1
===> Checking files for sbcl-1.0.41
`/usr/ports/distfiles/sbcl-1.0.41-source.tar.bz2' is up to date.
(SHA256) sbcl-1.0.41-source.tar.bz2: OK
===> Extracting for sbcl-1.0.41
===> Patching for sbcl-1.0.41
2 out of 4 hunks failed--saving rejects to src/runtime/runtime.c.rej
***> patch-src_runtime_runtime.c did not apply cleanly
===> Ignoring patchfile patch-src_runtime_runtime.c.rej
*** Error code 1

Stop in /usr/ports/lang/sbcl (line 2241 of
/usr/ports/infrastructure/mk/bsd.port.mk).
*** Error code 1

Stop in /usr/ports/lang/sbcl (line 2116 of
/usr/ports/infrastructure/mk/bsd.port.mk).

-----------------------------------------------------------------

Here is the rejected patch :

$ cat patches/patch-src_runtime_runtime.c.rej

[snipped]


The fact that you have a .rej file in patches/ indicates that my patch
did not apply cleanly for you (the patch that patches the patches in
patches/)

I tested just now and it applies fine against a clean tree, with -E to
remove all the obsolete patches. Are you sure that your ports tree was
clean and updated to HEAD when you applied the patch from my email?

I think because i tried multiple times using this command :

cd /usr/ports&& rm -rf lang/sbcl&& cvs up lang/sbcl&& patch -E<
sbcl-1.0.41.diff


I realize maybe thunderbird messed the patch being taken as message
body. I'll try with evolution but could you please send it as an
attachment also ?


Here's the original patch I sent to the list:

http://www.elsasser.org/misc/ports-sbcl-1.0.41-ppc.diff

Are you sure you are updating to HEAD and not a branch or something?
You might want to update with -A. Also, are you sure that the cvs
mirror is up to date?

Thanks. CVS was ok, it was thunderbird mangling two lines with ^L. Now
to some real testing, your patch applies neatly =)

I think you forgot to 'make plist'. When i do, my pkg/PLIST has several more .fasl files in it.

Otherwise regressions tests run OK !

Too bad there are no support for OpenBSD threads on SBCL yet, i wonder how much effort it would be to add. Common Lisp and OpenBSD ought to work together, they would definitely provide a major "Do The Right Thing" environment.

$ uname -a
OpenBSD adrenochrome.my.domain 4.8 GENERIC.MP#297 amd64

$ cd /usr/ports/lang/sbcl && make regress
[...]
Finished running tests.
Status:
 Expected failure:    packages.impure.lisp / USE-PACKAGE-CONFLICT-SET
 Expected failure:    packages.impure.lisp / IMPORT-SINGLE-CONFLICT
ok
//apparent success (reached end of run-tests.sh normally)
Tue Aug 17 03:16:56 CEST 2010

--
Thomas de Grivel
http://b.lowh.net/billitch

Reply via email to