On Sat, Jul 24, 2010 at 02:26:56PM +0100, Stuart Henderson wrote:
> On 2010/07/24 14:23, viq wrote:
> > This looks ok and builds fine on amd64, though a couple comments:
> > 
> > Personally as this is only a library I think I would put it in devel
> 
> If some place other than devel/ makes sense, I think it's better to use
> it, devel is huge already.

Understood.
 
> > The configure script picks up ggrep and gsed when installed, I found
> > some tricks to force the base ones to be used, do we want to bother?
> 
> Only if they make it into the packages..if it's only using it for build
> and providing build works either way, it's alright to leave it.

grepping strings in libs revealed nothing, so I guess it's fine.

> > I see explicit "use ssl" flag, so the complaints about not finding
> > gnutls are ignorable, but what about libidn?

So, do we want it to find and use libidn?

> > -- 
> > viq
> 

-- 
viq

Attachment: pgpxfCl0QVvSd.pgp
Description: PGP signature

Reply via email to