On 2010/07/16 11:49, Kevin Lo wrote:
> On Thu, 2010-07-15 at 09:09 +0100, Stuart Henderson wrote:
> > On 2010/07/15 10:37, Kevin Lo wrote:
> > > Hi,
> > > 
> > > This diff brings gmapcatcher to 0.7.1.0 which fixes the 
> > > 'huge red cross' tile showed at the searched location.
> > 
> > Well, swaps it for a huge red blob ;-) Looking at
> > http://code.google.com/p/gmapcatcher/wiki/Screenshots#GMapCatcher_v0.6
> > it seems it should actually be partially transparent, but it's opaque
> > for me.
> 
> It's opaque for me as well on both Windows and OpenBSD...
> 
> > >  pre-configure:
> > >   @find ${WRKSRC} -name \*.py | \
> > >       xargs perl -i -pe 's,^#!/usr/bin/env python,#!${MODPY_BIN},'
> > > + tr -d '\r' < ${WRKSRC}/download.py > ${WRKSRC}/download.py.new && \
> > > +     mv ${WRKSRC}/download.py.new ${WRKSRC}/download.py
> > 
> > Fixing line-endings doesn't seem to be necessary in this file,
> > do you see any problems if you just leave this out? If it is necessary
> > I'd rather do this in pre-patch to make it easier for anyone who wants
> > to patch that file later..
> 
> It's necessary. Already explained on icb :-)
> 
> > The setuptools parts seem a bit messy but no big worries there.
> 
> Those parts refer to net/emesene. Attached is an updated diff to move
> a line-endings fix in pre-patch. 
> ok?

Yes, ok. Thanks!

Reply via email to