On 2010/07/07 12:57, David Coppa wrote: > P.S.: I've also removed default cflags from config.mk. They are pointless > and gcc 3.3.5 doesn't know what to do with "-Wextra"... > > +-# default CFLAGS > +-CFLAGS ?= -g -O2
It's pointless to remove this, it's ?= so it's already overridden by the ports infrastructure, better to not touch things in patches unless it's needed, everything you change increases the chances of a conflicting patch in the future.. > +-CFLAGS += -Wall -Wextra -pedantic Ah, I didn't realise this was bad with gcc3. Personally I'd just zap -Wextra on this line and leave the others, but either way is ok with me.
