On 2010/06/30 21:51, Abel Abraham Camarillo Ojeda wrote:
> Stuart Henderson <s...@spacehopper.org> wrote:
>
> > On 2010/06/29 18:12, Abel Abraham Camarillo Ojeda wrote:
> > > Adds support for RADIUS Accounting, this needs p5-Data-HexDump already
> > > ported, posting it soon.
> > >
> > > I'm taking mantainership on it if nobody cares (it doesn't had a
> > > MANTAINER).
> >
> > Mangled quoted-printable diff, please fix your mail config and resend.
> >
>
> Is this ok?
the mail is ok now, but the diff is not quite ok -
> +DISTFILES = RadiusPerl-0.15.tar.gz
this is the wrong way to handle it, use DISTNAME and WRKDIST instead.
my diff below also installs the dictionaries, but leaves them in
share/examples, to avoid conflicting with existing files people might
have in /etc/raddb.
I also fixed the test, which was waiting for input on a
blank screen for me - now it asks the questions, as it should.
ok?
Index: Makefile
===================================================================
RCS file: /cvs/ports/security/p5-Authen-Radius/Makefile,v
retrieving revision 1.12
diff -u -p -r1.12 Makefile
--- Makefile 15 Sep 2007 23:29:59 -0000 1.12
+++ Makefile 1 Jul 2010 08:30:15 -0000
@@ -3,10 +3,12 @@
COMMENT= Perl module to authenticate against a RADIUS server
MODULES= cpan
-DISTNAME= RadiusPerl-0.05
-PKGNAME= p5-Authen-Radius-0.05p1
+DISTNAME= RadiusPerl-0.15
+PKGNAME= p5-Authen-Radius-0.15
CATEGORIES= security
+MAINTAINER= Abel Abraham Camarillo Ojeda <acam...@the00z.org>
+
# Perl
PERMIT_PACKAGE_CDROM= Yes
PERMIT_PACKAGE_FTP= Yes
@@ -14,15 +16,20 @@ PERMIT_DISTFILES_CDROM= Yes
PERMIT_DISTFILES_FTP= Yes
MASTER_SITES= ${MASTER_SITE_PERL_CPAN:=Authen/}
+WRKDIST= ${WRKDIR}/${DISTNAME:S/RadiusPerl/Authen-Radius/}
-RUN_DEPENDS= :p5-MD5->=1.7:security/p5-MD5
+RUN_DEPENDS= :p5-MD5->=1.7:security/p5-MD5 \
+ :p5-Data-HexDump->=0.02:devel/p5-Data-HexDump
BUILD_DEPENDS= ${RUN_DEPENDS}
REGRESS_IS_INTERACTIVE= Yes
-do-install:
- ${INSTALL_DATA_DIR} ${PREFIX}/${P5SITE}/Authen/
- ${INSTALL_SCRIPT} ${WRKDIR}/${DISTNAME}/Authen/Radius.pm \
- ${PREFIX}/${P5SITE}/Authen/Radius.pm
+pre-configure:
+ perl -pi -e \
+ s,/etc/raddb,${WRKINST}/${PREFIX}/share/examples/p5-Authen-Radius, \
+ ${WRKSRC}/install-radius-db.PL
+
+regress:
+ cd ${WRKSRC}; make test
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/security/p5-Authen-Radius/distinfo,v
retrieving revision 1.3
diff -u -p -r1.3 distinfo
--- distinfo 5 Apr 2007 17:26:08 -0000 1.3
+++ distinfo 1 Jul 2010 08:30:15 -0000
@@ -1,5 +1,5 @@
-MD5 (RadiusPerl-0.05.tar.gz) = tFW9lo0wdvdJ8dm6edF29g==
-RMD160 (RadiusPerl-0.05.tar.gz) = o70UNgprVDxtr8/1Gcn9YGCK1r8=
-SHA1 (RadiusPerl-0.05.tar.gz) = ELDpKOojLgnuMq0AVjj8hGYZesg=
-SHA256 (RadiusPerl-0.05.tar.gz) = k30cpy+nOf+U7KCIlDp8v3TJCGhFFA1OaaJlBMTaNII=
-SIZE (RadiusPerl-0.05.tar.gz) = 6309
+MD5 (RadiusPerl-0.15.tar.gz) = iEPqVp+ZVsKxyZISXbgfdQ==
+RMD160 (RadiusPerl-0.15.tar.gz) = 8BZl/QrjIKeLJk7Bfxlvk3RHmmc=
+SHA1 (RadiusPerl-0.15.tar.gz) = T10Lluz9xEJsDKlvDytu9l/oBSs=
+SHA256 (RadiusPerl-0.15.tar.gz) = pM9a1iEAcEqvf+6QGj3JdBFaMgoY7wTO9rRetSb69IM=
+SIZE (RadiusPerl-0.15.tar.gz) = 35049
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/security/p5-Authen-Radius/pkg/PLIST,v
retrieving revision 1.4
diff -u -p -r1.4 PLIST
--- pkg/PLIST 15 Sep 2004 18:36:01 -0000 1.4
+++ pkg/PLIST 1 Jul 2010 08:30:15 -0000
@@ -1,3 +1,16 @@
@comment $OpenBSD: PLIST,v 1.4 2004/09/15 18:36:01 espie Exp $
${P5SITE}/Authen/
${P5SITE}/Authen/Radius.pm
+...@man man/man3p/Authen::Radius.3p
+share/examples/p5-Authen-Radius/
+share/examples/p5-Authen-Radius/dictionary
+share/examples/p5-Authen-Radius/dictionary.ascend
+share/examples/p5-Authen-Radius/dictionary.cisco
+share/examples/p5-Authen-Radius/dictionary.compat
+share/examples/p5-Authen-Radius/dictionary.livingston
+share/examples/p5-Authen-Radius/dictionary.quintum
+share/examples/p5-Authen-Radius/dictionary.shiva
+share/examples/p5-Authen-Radius/dictionary.tunnel
+share/examples/p5-Authen-Radius/dictionary.usr
+share/examples/p5-Authen-Radius/dictionary.versanet
+share/examples/p5-Authen-Radius/dictionary.xtradius
