On Mon, May 17, 2010 at 12:16:27AM +0000, Jona Joachim wrote:
> On 2010-05-16, Matthias Kilian <[email protected]> wrote:
> > Let Cabal-generated register.sh and unregister.sh scripts pass
> > paraemters to ghc-pkg. Remove the (now obsolete) patch for Register.hs.
> >
> > Ports that build ghc libraries should now use the following
> > @exec/@unexec magic (('ve already diffs for all the hs-* ports in
> > my tree):
> >
> > lib/${DISTNAME}/register.sh
> > @exec /usr/bin/env HOME=/nonexistent %D/lib/${DISTNAME}/register.sh -v0
> > @unexec /usr/bin/env HOME=/nonexistent %D/lib/${DISTNAME}/unregister.sh -v0 
> > --force
> > lib/${DISTNAME}/unregister.sh
> 
> Why not hard-code the parameters (at least -v0) into the respective scripts?

That's what we had previously for unregister.sh, but IMHO it's
better to let the scripts themselves be a little bit more flexible.
I also think that the patch has a better chance to be accepted by
upstream ([email protected]) than patches that enforce -v0
(and even --force for unregister.sh).

Ciao,
        Kili

Reply via email to