On Tue, May 11, 2010 at 08:54:52AM +0200, David Coppa wrote:
> Hi all,
> 
> This fixes library linking for imlib2.
> Otherwise, some ports that use imlib2 can make a 
> fool of lib-depends-check. E.g. graphics/feh:
> 
> ===>  Building package for feh-1.3.4p0
> Create /usr/ports/packages/i386/all/feh-1.3.4p0.tgz
> 
> /usr/ports/packages/i386/all/feh-1.3.4p0.tgz:
> Extra:         pthread-stubs.0
> Extra:         xcb.2
> 
> Comments? OKs?

I see this in many other ports as well.  they have X11, pthread-stubs
and xcb in WANTLIB, but lib-depends-check complains about pthread-stubs
and xcb being "Extra".

acer:~% ldd /usr/X11R6/lib/libX11.so.12.0  
/usr/X11R6/lib/libX11.so.12.0:
        Start    End      Type Open Ref GrpRef Name
        03d7a000 23df5000 dlib 1    0   0      /usr/X11R6/lib/libX11.so.12.0
        0a955000 2a95a000 rlib 0    1   0      /usr/X11R6/lib/libxcb.so.2.1
        089a7000 289ab000 rlib 0    2   0      
/usr/X11R6/lib/libpthread-stubs.so.0.0
        0a709000 2a70d000 rlib 0    2   0      /usr/X11R6/lib/libXau.so.9.0
        074de000 274e3000 rlib 0    2   0      /usr/X11R6/lib/libXdmcp.so.10.0
acer:~% 

as far as your patch, wouldn't it make sense to add -lXau and -lXdmcp as
well?

but I wonder if this is a problem to be fixed in lib-depends-check?
I mean, shouldn't libraries that WANTLIBS depends on be WANTLIBS
themselves?

-- 
jake...@sdf.lonestar.org
SDF Public Access UNIX System - http://sdf.lonestar.org

Reply via email to