On Sun, Mar 21, 2010 at 06:38:32PM +0100, Tobias Ulmer wrote: > > Looks good, but shouldn't SHARED_LIBS start from 0.0 and have a comment for > > the > > upstream lib version. For example in devel/libdvdread: > > > > SHARED_LIBS += dvdread 4.3 # .5.1 > > I'm not sure about the 0.0 thing. Reading the shared library porting > documentation, I think it should also include USE_LIBTOOL=Yes.
man bsd.port.mk: The intent is that the OpenBSD ports system must have con- trol over shared library versions because of global changes that may require bumping the major version of every shared library in the system, or simply because the third party programmers do not understand the rules for shared library versions, thus breaking the update mechanism. For that reason it is advised to set libversion to 0.0 when first importing a port. > Update with those two things fixed is attached Looks good, fine by me. -- Best Regards Edd Barrett http://www.theunixzoo.co.uk
