On Sat, Dec 26, 2009 at 02:13:15AM +0000, Jacob Meuser wrote:
> I didn't realize until I started working on it that the port currently
> doesn't build sound support. I went ahead and made it compile sndio
> support anyway. but when I went to test it, afaics, cgoban never
> even tries to open the audio device. I'm not familiar with this
> program (no do I know how to play Go). anyone know how to get cgoban
> to make sounds?
>
> oh, I also made it respect CFLAGS during configure, so at least it
> wasn't a total waste of time ;)
Sorry for the delay. I just double checked and the original code does
not have sounds. Furthermore, it's in the TODO, so it cannot be tested
without changing the code. As cgoban is not longer maintained upstreams,
I'll say it's your call.
A few other comments on your diff.
- Add spaces around = as per Makefile.template
- pthreads-stubs and xcb are not longer needed as per
port-lib-depends-check
Rest looks good. I've played a few games against gnugo without problems.
Ok by me.
f.-
